[drake_bazel_external] Port to use MODULE.bazel #348
Conversation
jwnimmer-tri
force-pushed
the
bazel-external-bzlmod
branch
from
0d842b2 to
aa2c55c
Compare
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, platform LGTM missing (waiting on @jwnimmer-tri)
drake_bazel_external/MODULE.bazel line 35 at r2 (raw file):
module_name = "drake", urls = [x.format(DRAKE_COMMIT) for x in [ "https://github.com/jwnimmer-tri/drake/archive/{}.tar.gz",
Working
Revert after the Drake PR lands.
There was a problem hiding this comment.
+@SeanCurtis-TRI for feature review.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee seancurtis-tri, platform LGTM missing (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM from [seancurtis-tri] (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, platform LGTM from [seancurtis-tri] (waiting on @jwnimmer-tri)
drake_bazel_external/apps/BUILD.bazel line 83 at r2 (raw file):
pybind_py_library( name = "simple_adder_py", cc_binary_rule = cc_binary,
Working
Ah, I'd forgotten about this change. Since I originally wrote it, I've tried to make further edits to Drake that so that the tweaks here are no longer necessary. I'll play around to see if I can undo all changes to this file.
jwnimmer-tri
force-pushed
the
bazel-external-bzlmod
branch
from
aa2c55c to
751556e
Compare
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, platform LGTM from [seancurtis-tri] (waiting on @SeanCurtis-TRI)
drake_bazel_external/apps/BUILD.bazel line 83 at r2 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
Ah, I'd forgotten about this change. Since I originally wrote it, I've tried to make further edits to Drake that so that the tweaks here are no longer necessary. I'll play around to see if I can undo all changes to this file.
Yay, no changes actually needed for user BUILD files. Reverted.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM from [seancurtis-tri] (waiting on @jwnimmer-tri)
jwnimmer-tri
force-pushed
the
bazel-external-bzlmod
branch
from
751556e to
d7feb1a
Compare
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, platform LGTM from [seancurtis-tri] (waiting on @SeanCurtis-TRI)
drake_bazel_external/MODULE.bazel line 35 at r2 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
Revert after the Drake PR lands.
Done
|
+@ggould-tri for platform review, please. |
jwnimmer-tri
force-pushed
the
bazel-external-bzlmod
branch
from
d7feb1a to
76257f4
Compare
There was a problem hiding this comment.
Reviewed 5 of 8 files at r1, 1 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM from [seancurtis-tri, ggould-tri] (waiting on @jwnimmer-tri)
drake_bazel_external/MODULE.bazel line 16 at r4 (raw file):
# By default, this example always uses the latest Drake master branch. DRAKE_COMMIT = "master" DRAKE_CHECKSUM = ""
BTW: Although I'm confident that this is correct, I can't find it documented anywhere that this is the correct "don't care" default sentinel value.
jwnimmer-tri
force-pushed
the
bazel-external-bzlmod
branch
from
76257f4 to
395e482
Compare
There was a problem hiding this comment.
FYI I added one new snippet for macOS support. It's not covered by DEE CI (we don't officially support drake_bazel_external on macOS) but RobotLocomotion/drake#22435 reminded me it would be necessary.
Reviewable status:
drake_bazel_external/MODULE.bazel line 16 at r4 (raw file):
Previously, ggould-tri wrote…
BTW: Although I'm confident that this is correct, I can't find it documented anywhere that this is the correct "don't care" default sentinel value.
I can't fine any either, but anyway probably using None is epsilon less worrysome.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:
Towards RobotLocomotion/drake#20731.
This change is